Add Mypy checks to tests #1353
Merged
Add Mypy checks to tests #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminalaee
commented
Dec 8, 2021
| @@ -422,13 +422,13 @@ async def subdomain_app(scope, receive, send): | |||
| await response(scope, receive, send) | |||
|
|
|||
|
|
|||
| subdomain_app = Router( | |||
| subdomain_router = Router( | |||
There was a problem hiding this comment.
The name clashes with the already defined subdomain_app.
Add support for functools.partial in WebsocketRoute (#1356) * Add support for functools.partial in WebsocketRoute * remove commented code * Refactor tests for partian endpoint and ws Fix snippet on config.md (#1358) * Fix snippet on config.md * Update docs/config.md Co-authored-by: Amin Alaee <mohammadamin.alaee@gmail.com> Co-authored-by: Amin Alaee <mohammadamin.alaee@gmail.com> remove outdated test
aminalaee
force-pushed
the
add-mypy-check-to-tests
branch
from
ab39d45
to
bcddbc0
Compare
adriangb
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1045.
Adds Mypy checks to the tests.
I'll add a few comments where it can be confusing to review this.