Add generic typing for TestClient #1769
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singingwolfboy
force-pushed
the
generic-testclient
branch
from
d440fa2
to
d4e0c57
Compare
Kludex
reviewed
Jul 21, 2022
There was a problem hiding this comment.
- We are avoiding changes to the
TestClientuntil we make a decision on Replace HTTP client on TestClient fromrequeststohttpx#1376 .
To not let you fully down, I guess you can use either of the following suggestions:
- @adriangb 's suggestion: Generic typing for TestClient #1768 (comment). But I see your point...
- Inherit Starlette's
TestClient, and perform the changes you made on this PR.
Understandable. Thanks for letting me know! |
|
Let's first discuss this on the discussion. 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows developers to provide more detailed typing information for their
TestClientusage, which is helpful when trying to refer to the.appproperty on aTestClient.