Remove note about BackgroundTasks being a limitation on the BaseHTTPMiddleware
#1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriangb
reviewed
Sep 27, 2022
docs/middleware.md
Outdated
| ### Limitations | ||
| ### Limitation |
There was a problem hiding this comment.
I think we can keep this plural and keep it a list even if there is only 1 currently known limitation
There was a problem hiding this comment.
Do you intend to extend this list? 🤔
There was a problem hiding this comment.
Not necessarily, I still think it's better style, but that's just my opinion, not a blocker so I'm approving the PR regardless
adriangb
approved these changes
Sep 27, 2022
aminalaee
pushed a commit
that referenced
this pull request
Feb 13, 2023
…TPMiddleware` (#1874) Co-authored-by: Adrian Garcia Badaracco <1755071+adriangb@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.