Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove databases from tests #1919

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Conversation

Kludex
Copy link
Sponsor Member

@Kludex Kludex commented Oct 20, 2022

It looks like databases was a dependency when DatabaseMiddleware was still a thing.

I'm trying to understand the need for this test file. Is it needed? 🤔

Copy link
Member

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it needed? 🤔

Nope. Take this appendix out, doctor. 👨‍⚕️

@Kludex Kludex merged commit ab70211 into encode:master Oct 20, 2022
@Kludex Kludex deleted the remove-databases-tests branch October 20, 2022 19:22
aminalaee pushed a commit that referenced this pull request Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants