Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support the WebSocket Denial Response ASGI extension #2041

Merged
merged 51 commits into from
Feb 4, 2024
Merged

Support the WebSocket Denial Response ASGI extension #2041

merged 51 commits into from
Feb 4, 2024

Commits on Jan 20, 2024

  1. supply asgi_extensions to TestClient

    @kristjanvalur @Kludex
    kristjanvalur authored and Kludex committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    83f863d View commit details
    Browse the repository at this point in the history

  2. Add WebSocket.send_response()

    @kristjanvalur @Kludex
    kristjanvalur authored and Kludex committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    2e311be View commit details
    Browse the repository at this point in the history

  3. Add response support for WebSocket testclient

    @kristjanvalur @Kludex
    kristjanvalur authored and Kludex committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    936a075 View commit details
    Browse the repository at this point in the history

  4. fix test for filesystem line-endings

    @kristjanvalur @Kludex
    kristjanvalur authored and Kludex committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    b0edc2b View commit details
    Browse the repository at this point in the history

  5. lintint

    @kristjanvalur @Kludex
    kristjanvalur authored and Kludex committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    a230ba5 View commit details
    Browse the repository at this point in the history

  6. support websocket.http.response extension by default

    @kristjanvalur @Kludex
    kristjanvalur authored and Kludex committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    86ff3a1 View commit details
    Browse the repository at this point in the history

  7. Improve coverate

    @kristjanvalur @Kludex
    kristjanvalur authored and Kludex committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    9c6ddc4 View commit details
    Browse the repository at this point in the history

  8. Apply suggestions from code review 

    Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
    @kristjanvalur @Kludex
    kristjanvalur and Kludex committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    9e9773c View commit details
    Browse the repository at this point in the history

  9. Undo unrelated change

    @kristjanvalur @Kludex
    kristjanvalur authored and Kludex committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    73e29f7 View commit details
    Browse the repository at this point in the history

  10. fix incorrect error message

    @kristjanvalur @Kludex
    kristjanvalur authored and Kludex committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    5ee468a View commit details
    Browse the repository at this point in the history

  11. Update starlette/websockets.py 

    Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
    @kristjanvalur @Kludex
    kristjanvalur and Kludex committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    e2f609d View commit details
    Browse the repository at this point in the history

  12. formatting

    @kristjanvalur @Kludex
    kristjanvalur authored and Kludex committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    ce56778 View commit details
    Browse the repository at this point in the history

  13. Re-introduce close-code and close-reason to WebSocketReject

    @kristjanvalur @Kludex
    kristjanvalur authored and Kludex committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    07c0e36 View commit details
    Browse the repository at this point in the history

  14. Make sure the "websocket.connect" message is received in tests

    @kristjanvalur @Kludex
    kristjanvalur authored and Kludex committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    87c89a8 View commit details
    Browse the repository at this point in the history

  15. Deliver a websocket.disconnect message to the app even if it closes/r… 

    …ejects itself.
    @kristjanvalur @Kludex
    kristjanvalur authored and Kludex committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    1af1d8b View commit details
    Browse the repository at this point in the history

  16. Add test for filling out missing websocket.disconnect code

    @kristjanvalur @Kludex
    kristjanvalur authored and Kludex committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    48330b2 View commit details
    Browse the repository at this point in the history

  17. Add rejection headers. Expand tests.

    @kristjanvalur @Kludex
    kristjanvalur authored and Kludex committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    f075b02 View commit details
    Browse the repository at this point in the history

  18. Fix types, headers in message are bytes tuples.

    @kristjanvalur @Kludex
    kristjanvalur authored and Kludex committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    f132f7b View commit details
    Browse the repository at this point in the history

  19. Minimal WebSocket Denial Response implementation

    @Kludex
    Kludex committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    7e65b30 View commit details
    Browse the repository at this point in the history

  20. Revert "Minimal WebSocket Denial Response implementation" 

    This reverts commit 7af10dd.
    @Kludex
    Kludex committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    5ed6ade View commit details
    Browse the repository at this point in the history

  21. Rename to send_denial_response and update documentation

    @Kludex
    Kludex committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    d882c19 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. Remove the app_disconnect_msg. This can be added later in a separate PR

    @kristjanvalur
    kristjanvalur committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    2ffed52 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2024

  1. Remove status code 1005 from this PR

    @kristjanvalur
    kristjanvalur committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    4c188cd View commit details
    Browse the repository at this point in the history

  2. Assume that the application has tested for the extension before sendi… 

    …ng websocket.http.response.start
    @kristjanvalur
    kristjanvalur committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    24fc617 View commit details
    Browse the repository at this point in the history

  3. Rename WebSocketReject to WebSocketDenialResponse

    @kristjanvalur
    kristjanvalur committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    4fc34f1 View commit details
    Browse the repository at this point in the history

  4. Remove code and status from WebSocketDenialResponse. 

    Just send a regular WebSocketDisconnect even when connection is rejected with close()
    @kristjanvalur
    kristjanvalur committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    ca0d0b2 View commit details
    Browse the repository at this point in the history

  5. Raise an exception if attempting to send a http response and server d… 

    …oes not support it.
    @kristjanvalur
    kristjanvalur committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    5bda56e View commit details
    Browse the repository at this point in the history

  6. WebSocketDenialClose and WebSocketDenialResponse 

    These are both instances of WebSocketDenial.
    @kristjanvalur
    kristjanvalur committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    71b76e3 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. Update starlette/testclient.py 

    Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
    @kristjanvalur @Kludex
    kristjanvalur and Kludex committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    a508902 View commit details
    Browse the repository at this point in the history

  2. Revert "WebSocketDenialClose and WebSocketDenialResponse" 

    This reverts commit 71b76e3.
    @kristjanvalur
    kristjanvalur committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    550b132 View commit details
    Browse the repository at this point in the history

  3. Rename parameters, member variables

    @kristjanvalur
    kristjanvalur committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    3f76af9 View commit details
    Browse the repository at this point in the history

  4. Use httpx.Response as the base for WebSocketDenialResponse.

    @kristjanvalur
    kristjanvalur committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    ab85785 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2024

  1. Merge branch 'master' into kristjan/reject

    @Kludex
    Kludex committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    387cb15 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
    @kristjanvalur @Kludex
    kristjanvalur and Kludex committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    f7f4497 View commit details
    Browse the repository at this point in the history

  3. Update sanity check message

    @kristjanvalur
    kristjanvalur committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    7f0c902 View commit details
    Browse the repository at this point in the history

  4. Remove un-needed function

    @kristjanvalur
    kristjanvalur committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    991abc5 View commit details
    Browse the repository at this point in the history

  5. Expand error message test regex

    @kristjanvalur
    kristjanvalur committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    e536a03 View commit details
    Browse the repository at this point in the history

  6. Add type hings to test methods

    @kristjanvalur
    kristjanvalur committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    a561041 View commit details
    Browse the repository at this point in the history

  7. Add doc string to test.

    @kristjanvalur
    kristjanvalur committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    1e70746 View commit details
    Browse the repository at this point in the history

  8. Fix mypy complaining about mismatching parent methods.

    @kristjanvalur
    kristjanvalur committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    4f27aba View commit details
    Browse the repository at this point in the history

  9. nitpick & remove test

    @Kludex
    Kludex committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    f53efa6 View commit details
    Browse the repository at this point in the history

  10. Simplify the documentation

    @Kludex
    Kludex committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    dd90d1b View commit details
    Browse the repository at this point in the history

  11. Merge branch 'master' into kristjan/reject

    @Kludex
    Kludex committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    fa7c84e View commit details
    Browse the repository at this point in the history

  12. Update starlette/testclient.py

    @Kludex
    Kludex committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    9bd6db5 View commit details
    Browse the repository at this point in the history

  13. Update starlette/testclient.py

    @Kludex
    Kludex committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    721a2d2 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2024

  1. Remove an unnecessary test

    @kristjanvalur
    kristjanvalur committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    a70b7dd View commit details
    Browse the repository at this point in the history

  2. there is no special "close because of rejection" in the testclient an… 

    …ymore.
    @kristjanvalur
    kristjanvalur committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    0f4e1f2 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/kristjan/reject' into kristjan/r… 

    …eject
    @kristjanvalur
    kristjanvalur committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    04817a6 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into kristjan/reject

    @kristjanvalur
    kristjanvalur committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    bc3ecbd View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into kristjan/reject

    @Kludex
    Kludex committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    aa224dd View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into kristjan/reject

    @kristjanvalur
    kristjanvalur committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    094f080 View commit details
    Browse the repository at this point in the history