Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORS-middleware-use-explicit-origin-with-credentials #2119

Closed
wants to merge 2 commits into from
Closed

CORS-middleware-use-explicit-origin-with-credentials #2119

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1734427
test
swatiatdeliverect Apr 11, 2023
1811806
test
Swati-Sneha Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion starlette/middleware/cors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ def __init__(
self.allow_origin_regex = compiled_allow_origin_regex
self.simple_headers = simple_headers
self.preflight_headers = preflight_headers
self.allow_credentials = allow_credentials

async def __call__(self, scope: Scope, receive: Receive, send: Send) -> None:
if scope["type"] != "http": # pragma: no cover
Expand Down Expand Up @@ -160,7 +161,7 @@ async def send(

# If request includes any cookie headers, then we must respond
# with the specific origin instead of '*'.
if self.allow_all_origins and has_cookie:
if self.allow_all_origins and (has_cookie or self.allow_credentials):
self.allow_explicit_origin(headers, origin)

# If we only allow specific origins, then we have to mirror back
Expand Down