Add option timeout
to WebSocketTestSession::receive
#2329
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allows to pass a timeout to various receive methods of
WebSocketTestSession
which is passed intoQueue::get
.This allows to write tests that raise an exception (which can be expected as well) instead of blocking forever in case the tested app does not send a message on the websocket.
It is a potential fix for #2195, but allows finer control about which call to receive should have a timeout, and which should block instead of setting a generic timeout option to the Session.
Checklist