Add type hints to test_requests.py
#2481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
reviewed
Feb 4, 2024
tests/test_requests.py
Outdated
Comment on lines
24
to
28
| scope: typing.Dict[str, typing.Any], | ||
| receive: typing.Callable[[], typing.Awaitable[typing.Dict[str, typing.Any]]], | ||
| send: typing.Callable[ | ||
| [typing.MutableMapping[str, typing.Any]], typing.Awaitable[None] | ||
| ], |
There was a problem hiding this comment.
Why are you not using Scope, Receive, and Send?
There was a problem hiding this comment.
Updated those in all places in this file.
Just a small note:
There are some places where I have added: test_client_factory: typing.Any. In those places I get an error when i try to use the TestClientFactory:
example: Argument "data" to "post" of "TestClient" has incompatible type "str"; expected "Optional[Mapping[str, Union[str, Iterable[str]]]]"
Kludex
requested changes
Feb 4, 2024
tests/test_requests.py
Outdated
Comment on lines
12
to
17
| from starlette.types import ( | ||
| Message, | ||
| Receive, | ||
| Scope, | ||
| Send, | ||
| ) |
There was a problem hiding this comment.
Please fix those.
Suggested change
| from starlette.types import ( | |
| Message, | |
| Receive, | |
| Scope, | |
| Send, | |
| ) | |
| from starlette.types import Message, Receive, Scope, Send |
…arlette into improve-types/test_requests
TechNiick
changed the title
test_requests.py
Kludex
requested changes
Feb 5, 2024
Kludex
requested changes
Feb 5, 2024
TechNiick
changed the title
test_requests.pytest_requests.py
Kludex
approved these changes
Feb 6, 2024
nixroxursox
pushed a commit
to nixroxursox/starlette
that referenced
this pull request
Mar 18, 2024
* added type annotations to test_requests.py * requested changes * indentations * typos * typos * Apply suggestions from code review * Apply suggestions from code review --------- Co-authored-by: Scirlat Danut <scirlatdanut@scirlats-mini.lan> Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to this
Type annotation added to
test_requests.pyChecklist