Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP/RFC] Store request in scope #498

Closed
wants to merge 2 commits into from
Closed

[WIP/RFC] Store request in scope #498

wants to merge 2 commits into from

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented May 1, 2019 •
edited
Loading

Ref: #497

@blueyed blueyed changed the title Store request in scope [WIP/RFC] Store request in scope May 1, 2019
@blueyed
Copy link
Contributor Author

blueyed commented May 1, 2019

This is useful for templating already, but also when using Starlette with other frameworks/apps, e.g. django-channels, and you want to have e.g. shared template processors (which could then use Starlette's or Django's request).

@blueyed blueyed mentioned this pull request May 1, 2019
Closed
@gwdekker
Copy link

gwdekker commented May 2, 2019

This would also help with #493 (and maybe #489 ?)

@tomchristie
Copy link
Member

Closing as per #497.

@tomchristie tomchristie closed this May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@blueyed @gwdekker @tomchristie