Call exception handlers even if response started #758
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge from head
tomchristie
reviewed
Dec 18, 2019
… it's yet to be rendered
aviramha
force-pushed
the
exceptions_refactor
branch
from
fb267fe
to
fade736
Compare
|
Added tests, 100% coverage :) |
tomchristie
reviewed
Dec 18, 2019
| @@ -58,11 +58,26 @@ def test_websockets_should_raise(): | |||
|
|
|||
|
|
|||
| def test_handled_exc_after_response(): | |||
| # A 406 HttpException is raised *after* the response has already been sent. | |||
| # The exception middleware should raise a RuntimeError. | |||
| with pytest.raises(RuntimeError): | |||
There was a problem hiding this comment.
I would change the test much more simply here. A handled exception after the response is rendered isn't a problem now, we should just expect a 200 status code. We don't particularly need to check for side-effects.
There was a problem hiding this comment.
Wouldn't we want to make sure that the exception handler runs? In case the response is already rendered, we get the same result even if it's not called
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows background tasks exceptions to be caught by exception handlers.
The implication is that handlers are always called, but response is rendered by the handlers only if not rendered yet.
** THIS IS A DRAFT ** I will add tests and document changes after initial approval.