New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't partially enforce CORS server-side #93

Merged

tomchristie merged 2 commits into master from minor-cors-tweaks

Oct 9, 2018

Member

tomchristie commented Oct 9, 2018

Refs #92

Use compiled_allow_origin_regex variable, for consistent typing.
Ensure the allowed_origin_regex does not strictly override allow_origins - both may be used.
Don't partial enforce CORS server-side. (If we want to do enforcement then we'll want to also check headers, credentials, etc...)

tomchristie added 2 commits

October 9, 2018 09:46


          Don't partially enforce CORS server-side

f4d14d7


          Comment on CORS enforcement

c4a4bdf

tomchristie merged commit d505abc into master

tomchristie deleted the minor-cors-tweaks branch

October 9, 2018 09:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment