🐛 Fix resetting signals in Gunicorn UvicornWorker (#895)

* 🐛 Fix resetting signals in Gunicorn UvicornWorker to fix subprocesses that capture output having an incorrect returncode * Update uvicorn/workers.py Co-authored-by: Florimond Manca <florimond.manca@gmail.com>
encode · Dec 29, 2020 · 36cfe87 · 36cfe87
1 parent 091571b
commit 36cfe87
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/uvicorn/workers.py b/uvicorn/workers.py
@@ -1,5 +1,6 @@
 import asyncio
 import logging
+import signal
 
 from gunicorn.workers.base import Worker
 
@@ -62,7 +63,11 @@ def init_process(self):
         super(UvicornWorker, self).init_process()
 
     def init_signals(self):
-        pass
+        # Reset signals so Gunicorn doesn't swallow subprocess return codes
+        # other signals are set up by Server.install_signal_handlers()
+        # See: https://github.com/encode/uvicorn/issues/894
+        for s in self.SIGNALS:
+            signal.signal(s, signal.SIG_DFL)
 
     def run(self):
         self.config.app = self.wsgi