Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate WSGIMiddleware #1235

Closed
wants to merge 3 commits into from
Closed

Deprecate WSGIMiddleware #1235

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f66b533
Deprecate WSGIMiddleware
abersheeran Nov 6, 2021
25b4178
fixed pep8
abersheeran Nov 6, 2021
e581e04
fix DeprecationWarning
abersheeran Nov 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions uvicorn/middleware/wsgi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import concurrent.futures
import io
import sys
import warnings
from collections import deque
from typing import Deque, Iterable, Optional, Tuple

Expand Down Expand Up @@ -72,6 +73,11 @@ def build_environ(scope: HTTPScope, message: ASGIReceiveEvent, body: bytes) -> E

class WSGIMiddleware:
def __init__(self, app: WSGIApp, workers: int = 10):
warnings.warn(
"The built-in `WSGIMiddleware` will be deprecated in"
" future versions, please use `a2wsgi.WSGIMiddleware` instead.",
DeprecationWarning,
)
self.app = app
self.executor = concurrent.futures.ThreadPoolExecutor(max_workers=workers)

Expand Down