New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve logging test and increase coverage on server.py
#1743
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
adbc9b6
improve uds logging test and increase coverage
iudeen 872d5dd
add skip for win32
iudeen 08059cf
Add Client to test
iudeen 0dfa766
remove fixture
iudeen edb53e5
improve uds logging test and increase coverage
iudeen efc399e
add skip for win32
iudeen 74d7022
Add Client to test
iudeen 87c8b62
remove fixture
iudeen d7c0fbb
Remove pragma on fd
Kludex 1b4f770
Fix coverage
Kludex f147004
Merge branch 'fix/improve-cov-server' of https://github.com/iudeen/uv…
iudeen f0916ac
remove pragma
iudeen ad4ae14
add test for `fd` param
iudeen bd7553f
skip win32
iudeen 3631f70
Add tests for cases when port is `0`
iudeen 833aef0
Merge remote-tracking branch 'origin/master' into fix/improve-cov-server
iudeen 8804d7e
improve coverage on start up conditions
iudeen 8ac01a6
Merge branch 'encode:master' into fix/improve-cov-server
iudeen 2b0774c
Merge branch 'fix/improve-cov-server' of https://github.com/iudeen/uv…
iudeen 588dbd4
increase coverage threshold
iudeen 73b5367
Remove unwanted params from test and simply
iudeen 1ca64ae
revert: remove port zero test
iudeen aa5bc0e
revert: remove tests in test_main.py
iudeen 5729216
update coverage fail_under
iudeen File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add
# pragma: py-win32
because we usesocket.AF_UNIX
in all instances.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, you mean in the line after... Got it. Yep!