Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset lifespan state on each request #1903

Merged
merged 2 commits into from
Mar 16, 2023
Merged

Reset lifespan state on each request #1903

merged 2 commits into from
Mar 16, 2023

Conversation

Kludex
Copy link
Sponsor Member

@Kludex Kludex commented Mar 16, 2023

@Kludex Kludex requested review from adriangb and a team March 16, 2023 10:02
@Kludex Kludex mentioned this pull request Mar 16, 2023
Merged
1 task
@michaeloliverx
Copy link
Member

.copy() is shallow right? Do we need a note in the docs to highlight this?

@Kludex
Copy link
Sponsor Member Author

Kludex commented Mar 16, 2023

Where would you add it in the docs?

@michaeloliverx
Copy link
Member

Where would you add it in the docs?

Now that I think of it, it probably belongs in the framework level docs instead, ignore me.

@Kludex Kludex merged commit 4601d24 into master Mar 16, 2023
@Kludex Kludex deleted the fix/uvicorn-state branch March 16, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeloliverx michaeloliverx michaeloliverx approved these changes

@adriangb adriangb Awaiting requested review from adriangb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

with 'uvicorn==0.21.0' modifications made to the 'request.state' persist between requests
2 participants
@Kludex @michaeloliverx