Skip installation of signal handlers when not in main thread #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
weird this doesnt pass tests, looks it blocked on the config one ? |
Co-authored-by: euri10 <euri10@users.noreply.github.com>
euri10
approved these changes
Dec 1, 2020
|
@euri10 I'll merge this and then tentatively release as 0.13.0… I'm not sure whether this should be considered a new feature or a bug fix, but since it can potentially mean some people will have to undo some scaffolding, I'd treat this as an "Added" entry. |
This was referenced Dec 7, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one has been bogging me for a while, so here's a tentative pull request for it:
Since signals can only be listened to from the main thread, this PR modifies
.install_signal_handlers()to skip installation of signal handlers when not in the main thread:https://docs.python.org/3/library/signal.html#signals-and-threads
This way, we can also get rid of a bunch of boilerplate overrides of
.install_signal_handlers()in tests — and many other people will be able to as well (eg we do it in HTTPX, HTTPCore, many of my personal packages, and essentially anywhere one needs to run Uvicorn in a Python thread right now).Surprisingly enough I haven't found an issue open for this yet. :-) But this is somewhat related to #526 (although I don't think it's exactly fixing it).