Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wsgi middleware PATH_INFO encoding #962

Merged
merged 2 commits into from Feb 20, 2021
Merged

Fix wsgi middleware PATH_INFO encoding #962

merged 2 commits into from Feb 20, 2021

Conversation

CoolSpring8
Copy link
Contributor

Fix #961

@CoolSpring8
Copy link
Contributor Author

CoolSpring8 commented Feb 20, 2021 •
edited

I can see that SCRIPT_NAME seems to be tracked down by #937, so I just leave it untouched for now.

The original fix in encode/starlette#998 changes both PATH_INFO and SCRIPT_NAME because both have the encoding issue. But as SCRIPT_NAME in uvicorn wsgi middleware here is currently empty, nothing needs to be done now. ;)

euri10
euri10 approved these changes Feb 20, 2021
View reviewed changes
Copy link
Member

@euri10 euri10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot @CoolSpring8

@euri10 euri10 merged commit 2b1a67f into encode:master Feb 20, 2021
@CoolSpring8 CoolSpring8 deleted the wsgi-path-encoding branch February 20, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@euri10 euri10 euri10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WSGI middleware error in non-latin1 path
2 participants
@CoolSpring8 @euri10