major bump @polkadot deps #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clangenb
commented
Aug 20, 2022
| @@ -1,27 +1,27 @@ | |||
| { | |||
There was a problem hiding this comment.
The new build process formats the package.json in the same way as @polkadot does it
# Conflicts: # package.json # packages/types/package.json # yarn.lock
clangenb
commented
Aug 20, 2022
| @@ -75,7 +75,6 @@ export function extractEvents(api: ApiPromise, result: ISubmittableResult): IExt | |||
| try { | |||
| const mod = dispatchError.asModule; | |||
| const error = api.registry.findMetaError( | |||
| // @ts-ignore | |||
clangenb
commented
Aug 20, 2022
Comment on lines
-72
to
-75
|
|
||
| **WARN** When the packages are linked in the `js_encointer_service` and yarn install is run, it will create a | ||
| `node_modules` folder inside the build folder. Do NOT publish this one. However, with the above sequence, this will be | ||
| fine, as `yarn build` cleans the build directory first. |
There was a problem hiding this comment.
We don't use that any more, as yarn link does no longer exist with yarn v3
clangenb
commented
Aug 20, 2022
Comment on lines
+5
to
+12
| /// This file is almost identical to the one defined in `@polkadot-dev`. It is intended to normalize the publications | ||
| /// of `@polkadot` packages. However, it also performs some universally helpful code quality checks. This script does: | ||
| /// | ||
| /// * build the sources with`CommonJS` and `ESM` output. | ||
| /// * normalize the package.json's. | ||
| /// * lint the dependencies; make sure every import is indeed declared as a dependency. | ||
| /// * makes the output compatible with the new `deno` runtime: https://blog.logrocket.com/what-is-deno/. | ||
|
|
There was a problem hiding this comment.
The heart of the build process, and this is where the meat lies of this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feared that we will have to do this soon, as we were two major versions behind. So I thought I will do that endeavour now, as I have time, while there is no stress when potential blockers are discovered. However, this time it was less painful, even though I had to adjust the build-process once again.
I also already tested that the basics work in the encointer-wallet: https://github.com/encointer/encointer-wallet-flutter/tree/cl/major-bump-polkadot
Note: There were three preliminary PRs to this that I did not want to bother you with to speed up the process: