Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ceremonies] introduce checked math operations #90

Closed
clangenb opened this issue Dec 11, 2021 · 1 comment
Closed

[ceremonies] introduce checked math operations #90

clangenb opened this issue Dec 11, 2021 · 1 comment
Assignees
@NicJak

Comments

@clangenb
Copy link
Member

Most of it is performed with plain math operations that may fail due to: overflow, underflow, division by zero. This needs a proper cleanup, we must absolutely not have potential panics in the runtime.
@NicJak NicJak self-assigned this Dec 13, 2021
NicJak added a commit that referenced this issue Dec 16, 2021
@NicJak
[ceremonies/#90] add checked modulo operation
e4c394d
NicJak added a commit that referenced this issue Dec 19, 2021
@NicJak
[ceremonies/#90] add checked modulo operation
ebe0e69
NicJak added a commit that referenced this issue Dec 19, 2021
@NicJak
[ceremonies/#90] remove naked unwrap()
5e047e5
NicJak added a commit that referenced this issue Dec 19, 2021
@NicJak
[ceremonies/#90] enhancement of encapsulated checked math
a89896b
NicJak added a commit that referenced this issue Dec 20, 2021
@NicJak
[ceremonies/#90] enhance encapsulated checked math
128968f
NicJak added a commit that referenced this issue Dec 20, 2021
@NicJak
[ceremonies/#90] add safe prefix to non-checked math comments
6fad388
clangenb pushed a commit that referenced this issue Dec 22, 2021
@NicJak
[ceremonies/#90] add checked modulo operation (#92)
5ef991d 
* [ceremonies/#90] add checked modulo operation

* [ceremonies/#90] remove naked unwrap()

* [ceremonies/#90] enhance encapsulated checked math

* [ceremonies/#90] add safe prefix to non-checked math comments
@clangenb
Copy link
Member Author

clangenb commented Mar 3, 2022

This has been done.

@clangenb clangenb closed this as completed Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NicJak NicJak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@clangenb @NicJak