added fields AnnouncementSigner and CommunityRules to CommunityMetadata #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
caveat: the rpc reads CommunityMetadata.name and will break if this can't be decoded. therefore we need state migration (manual or automated) |
brenzi
changed the title
pifragile
reviewed
Jul 27, 2023
|
while parity tends to do single-step migrations, I believe this case here is much simpler to understand and comes with less boilerplate if we allow migration from v0->v2 and v1->v2 in a single move. v0->v1 was a noop with bound checks only |
clangenb
reviewed
Jul 28, 2023
clangenb
reviewed
Jul 29, 2023
clangenb
approved these changes
Jul 29, 2023
This was referenced Jul 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #334
closes #335
breaking change!
includes a storage migration to v2 for the communities pallet