Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip downloading label rows metadata when querying project using UserClient #312

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

sergei-encord
Copy link
Collaborator

@sergei-encord sergei-encord commented May 12, 2023

UserClient.get_project method currently receives all the rows metadata info when reads project information, and then immediately discards it. And this will cause significant unneeded delays, especially for big projects.
With explicitly opting out of receiving metadata along with the project this method will complete many times faster.

@github-actions
Copy link

Unit test report

96 tests   85 ✔️  2s ⏱️
  1 suites  11 💤
  1 files      0

Results for commit a306de9.

Copy link
Contributor

@denis-cord denis-cord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@sergei-encord sergei-encord merged commit 22b8c84 into master Jun 7, 2023
3 checks passed
@sergei-encord sergei-encord deleted the project-skip-label-metadata branch June 7, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants