Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error on setting dynamic answer #316

Merged
merged 4 commits into from
May 18, 2023

Conversation

sergei-encord
Copy link
Collaborator

ObjectInstance.set_answer throws an error when user tries to set an answer for dynamic attribute. This happens due to erroneous attempt to find dynamic attribute in the static answer map. Skipping this check for dynamic answers

@github-actions
Copy link

github-actions bot commented May 17, 2023

Unit test report

101 tests   90 ✔️  2s ⏱️
    1 suites  11 💤
    1 files      0

Results for commit 0c3aa6c.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@denis-cord denis-cord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably fine, a test case would be great to check that this does the job.

@sergei-encord sergei-encord force-pushed the fix-dynamic-annotation-answer branch from 1cfc983 to 0c3aa6c Compare May 17, 2023 15:16
Copy link
Contributor

@denis-cord denis-cord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if this test case failed before the changes. Thanks Sergei!

@sergei-encord sergei-encord merged commit 5ce6f99 into master May 18, 2023
3 checks passed
@sergei-encord sergei-encord deleted the fix-dynamic-annotation-answer branch May 18, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants