Add workflow_complete call to LabelRowV2 #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergei-encord
force-pushed
the
workflow-complete
branch
from
851429f
to
b8fa13d
Compare
sergei-encord
force-pushed
the
workflow-complete
branch
from
daac53f
to
07b226f
Compare
rad-cord
reviewed
May 24, 2023
rad-cord
approved these changes
May 24, 2023
denis-cord
reviewed
May 24, 2023
| pass | ||
|
|
||
|
|
||
| class LabelWorkflowGraphNodePayload(base_orm.BaseORM): |
There was a problem hiding this comment.
mhh I think we're trying to get rid of the base orms in general. Is there a good reason to use those over dataclasses?
There was a problem hiding this comment.
Not really, mostly for consistency and because it's serialisable to json by default.
dataclasses.asdict(obj) should be equally fine, I suppose.
If we want to bring pydantic and match server-side approach I guess is a separate question. Totally happy to discuss, but would vote for not making anything like that in scope of this PR
sergei-encord
force-pushed
the
workflow-complete
branch
from
9ce7e73
to
1b25efd
Compare
sergei-encord
force-pushed
the
workflow-complete
branch
from
1b25efd
to
b421617
Compare
Co-authored-by: david-babuschkin-encord <126681387+david-babuschkin-encord@users.noreply.github.com>
Co-authored-by: david-babuschkin-encord <126681387+david-babuschkin-encord@users.noreply.github.com>
Co-authored-by: david-babuschkin-encord <126681387+david-babuschkin-encord@users.noreply.github.com>
Co-authored-by: david-babuschkin-encord <126681387+david-babuschkin-encord@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.