Fix: SkeletonTemplates not creating Edges correctly #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Had a realisation that cls constructor would have saved me like an hours work |
sergei-encord
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction and Explanation
As quickly spotted by Laverne, the creation of templates did not wholly line up with the FE and was not making edges correctly. With a battle with serialisation logic, this now aligns carefully.
Documentation
Spotted on the way to the docs. Originally this logic was just to facilitate the testing of the handling of SkeletonCoordinates.
Tests
Tests have been amended on this end to inspect creation also of edges. Still passes tests on BE.
Known issues
I battled hugely with trying to keep BaseDTO and the aliasing class. The aliasing class was removed as the new parsing logic returns a SkeletonTemplateORM and then the logic would need to be repeated to make the aliasing class happy. This issue with the two types caused lots of confusion on my end. If we keep the two types, tests fail on SDK side where it is deserialised into ORM type and user creates interface type.
I'm not sure that there is a better solution, we could remove the redirection file and just share the type directly.