Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix User-Agent for generated client in JS and TS #1029

Merged
merged 3 commits into from Feb 26, 2024

Conversation

rewop
Copy link
Contributor

@rewop rewop commented Feb 13, 2024

It adds the User-Agent header to the requests only if the global window is undefined, which means the client is running on node.

Fixes #1020.

@encore-cla
Copy link

encore-cla bot commented Feb 13, 2024

All committers have signed the CLA.

@rewop rewop force-pushed the fix/clientgen-useragent-js-ts branch from 838e87b to c4557cf Compare February 13, 2024 20:47
Copy link
Member

@eandre eandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@eandre eandre enabled auto-merge (squash) February 26, 2024 10:20
@eandre eandre disabled auto-merge February 26, 2024 10:21
@eandre eandre merged commit ddcf9a7 into encoredev:main Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Javascript generated client triggers errors on User-Agent in browser
2 participants