cli/daemon: database improvements #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All committers have signed the CLA. |
eandre
reviewed
Dec 6, 2021
cli/daemon/run.go
Outdated
| @@ -236,38 +236,54 @@ func (s *Server) Test(req *daemonpb.TestRequest, stream daemonpb.Daemon_TestServ | |||
| } | |||
| s.cacheAppRoot(man.AppID, req.AppRoot) | |||
|
|
|||
| setupCtx, setupCancel := context.WithTimeout(context.Background(), 30*time.Second) | |||
| var usesSQLDB bool | |||
| for _, svc := range parse.Meta.Svcs { | |||
There was a problem hiding this comment.
This can be replaced with usesSQLDB := requiresSQLDB(parse.Meta)
There was a problem hiding this comment.
Missed it! Thanks. It's replaced now
horiajurcut
added a commit
to eandre/encore
that referenced
this pull request
Dec 14, 2021
Various improvements to database handling. Fixes encoredev#49, encoredev#98, encoredev#107
horiajurcut
added a commit
to horiajurcut/encore
that referenced
this pull request
Dec 21, 2021
Various improvements to database handling. Fixes encoredev#49, encoredev#98, encoredev#107
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #107 #98 #49