clientgen: fix handling of optionals #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a value is optional the ts/js clients need to handle the possibility the value is undefined. Thanks Ryan Content for the report. Fixes encoredev#725
|
All committers have signed the CLA. |
eandre
requested review from
ekerfelt and
DomBlack
and removed request for
ekerfelt
DomBlack
previously approved these changes
May 22, 2023
DomBlack
approved these changes
May 31, 2023
| @@ -152,7 +153,7 @@ func (g *Generator) newOperationForEncoding(rpc *meta.RPC, method string, reqEnc | |||
| AllowEmptyValue: true, | |||
| AllowReserved: false, | |||
| Deprecated: false, | |||
There was a problem hiding this comment.
Ohh nice, in the future we could even detect this and include it in the meta
There was a problem hiding this comment.
Yeah that's a good idea :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a value is optional the ts/js clients need to handle the possibility the value is undefined.
Thanks Ryan Content for the report.
Fixes #725