pubsub: add MethodHandler #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All committers have signed the CLA. |
eandre
force-pushed
the
pubsub-methodhandler
branch
3 times, most recently
from
89cee3e
to
805698d
Compare
This adds support for having Pub/Sub handlers that reference a method on a service struct.
eandre
force-pushed
the
pubsub-methodhandler
branch
from
805698d
to
95de6bb
Compare
DomBlack
reviewed
Jun 2, 2023
| // Allow the rest of the service to initialize before we connect to NSQD. | ||
| // This is necessary because NSQD is so fast the receiver can process messages | ||
| // before all package-level initialization functions have been called. | ||
| time.Sleep(100 * time.Millisecond) |
There was a problem hiding this comment.
Is there a better way to do this, than "100ms sleep" - this seems like we're just asking for trouble in the future; could there not be a apisdk.WaitForInit() method, which returns true once all services are init'ed
| // Handler: pubsub.MethodHandler((*MyService).MyMethod), | ||
| // // ... | ||
| // }) | ||
| func MethodHandler[T, SvcStruct any](handler func(s SvcStruct, ctx context.Context, msg T) error) func(ctx context.Context, msg T) error { |
There was a problem hiding this comment.
❤️ Perfect, adding support while keeping type satefy in the IDE
DomBlack
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for having Pub/Sub handlers that reference a method on a service struct.