Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support async functions in for auth generator in TS and JS generated clients #997

Merged
merged 8 commits into from Feb 12, 2024

Conversation

anish749
Copy link
Contributor

@anish749 anish749 commented Jan 9, 2024

fixes #995

@encore-cla
Copy link

encore-cla bot commented Jan 9, 2024

All committers have signed the CLA.

@anish749 anish749 marked this pull request as draft January 9, 2024 00:24
Copy link

github-actions bot commented Jan 9, 2024

Test Results

  2 files  +    1  227 suites  +63   15m 25s ⏱️ - 10m 1s
742 tests +  181  739 ✅ +  192  3 💤 +3  0 ❌  - 4 
742 runs   - 1 891  739 ✅  - 1 880  3 💤 +3  0 ❌  - 4 

Results for commit 5eb6531. ± Comparison against base commit 6f56db4.

This pull request removes 41 and adds 222 tests. Note that renamed tests count towards both.
encr.dev/e2e-tests ‑ TestRun/encore_currentrequest
encr.dev/e2e-tests ‑ TestRun/et_mocking
encr.dev/e2e-tests ‑ TestRun/et_override_user
encr.dev/e2e-tests ‑ TestRun/et_override_user_authdata
encr.dev/e2e-tests ‑ TestRun/experiment_local_secrets_override
encr.dev/e2e-tests ‑ TestRun/fallback_routes
encr.dev/e2e-tests ‑ TestRun/graceful_shutdown
encr.dev/e2e-tests ‑ TestRun/pubsub_method_handler
encr.dev/e2e-tests ‑ TestRun/pubsub_ref
test/svc ‑ TestEndToEndWithApp
…
encore.dev/appruntime/apisdk/api ‑ TestDescGeneratesTrace
encore.dev/appruntime/apisdk/api ‑ TestDescGeneratesTrace/echo
encore.dev/appruntime/apisdk/api ‑ TestDescGeneratesTrace/invalid
encore.dev/appruntime/apisdk/api ‑ TestDescGeneratesTrace/raw
encore.dev/appruntime/apisdk/api ‑ TestDescGeneratesTrace/unauthenticated
encore.dev/appruntime/apisdk/api ‑ TestDesc_EndToEnd
encore.dev/appruntime/apisdk/api ‑ TestDesc_EndToEnd/echo
encore.dev/appruntime/apisdk/api ‑ TestDesc_EndToEnd/invalid
encore.dev/appruntime/apisdk/api ‑ TestDesc_EndToEnd/unauthenticated
encore.dev/appruntime/apisdk/api ‑ TestRawEndpointOverflow
…

♻️ This comment has been updated with latest results.

@anish749 anish749 marked this pull request as ready for review January 21, 2024 14:42
@anish749 anish749 requested a review from eandre January 29, 2024 19:26
Copy link
Member

@eandre eandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@eandre eandre enabled auto-merge (rebase) February 9, 2024 18:30
@eandre eandre disabled auto-merge February 12, 2024 21:49
@eandre eandre merged commit 800c0f0 into encoredev:main Feb 12, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support async authDataGenerator in generated typescript client
2 participants