Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid compiler warning about unused function #40

Closed
javaprog opened this issue Jan 26, 2021 · 0 comments · Fixed by #42
Closed

Avoid compiler warning about unused function #40

javaprog opened this issue Jan 26, 2021 · 0 comments · Fixed by #42

Comments

@javaprog
Copy link
Contributor

PyModule_Create in compat.h is declared as static but not marked as inline. As a consequence, for complex Python C bindings consisting of multiple compilation units, the compiler will emit a warning about the function being unused (except for the compilation unit that actually uses it). Adding the keyword inline will discard the function in compilation units that don't use it.
javaprog added a commit to javaprog/py3c that referenced this issue Jan 26, 2021
@javaprog
Avoid warning about unused function, fixes encukou#40
164e1dd 
By marking the static function "inline", the compiler will only generate code for it if it is actually used. Without the keyword, the compiler will emit a warning if it is not used. For trivial Python C bindings this is not an issue, but if the code consists of multiple compilation units then this currently results in a warning for each such compilation unit without module initialization function.
encukou added a commit that referenced this issue Jan 26, 2021
@encukou
Avoid GCC warnings on unused functions
3360ee6 
Fixes: #40 (for GCC)

Making the functions `inline` would be better here, but `inline` is
not available in C90.

Includes tests to avoid future regressions :)
@encukou encukou mentioned this issue Jan 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid GCC warnings on unused functions encukou/py3c
1 participant
@javaprog