Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separator visibility options #141

Closed
GasDauMin opened this issue Dec 20, 2023 · 3 comments · Fixed by #142
Closed

Separator visibility options #141

GasDauMin opened this issue Dec 20, 2023 · 3 comments · Fixed by #142
Labels
enhancement New feature or request
Milestone

Comments

@GasDauMin
Copy link
Collaborator

I wanted to clarify if I understand correctly that the visibility of the separator is not controlled, if it is set, it will be set and there is no possibility to change it. If so, in this case, it would be very important to have the ability to control the visibility of the separator.

As is the case with me, I have described several menu items after the separator, but they are displayed under certain conditions (e.g., exceptions for file extensions, files, directories, etc.) and are not available in this context. Therefore, I would like to be able to control the separator itself.

Separator

@GasDauMin GasDauMin added the enhancement New feature or request label Dec 20, 2023
@end2endzone
Copy link
Owner

You are correct. The visibility of the separator is not controlled. I think that it would be a good addition to ShellAnything.

I do not think it would be that hard to implement. Change the parser to parse visibility/validity elements even when separator="true" is found. Change the menu renderer function BuildMenuTree() to test for visibility/validity even when Menu::IsSeparator() is true.

Would you be able to contribute again with this feature? I would gladly accept a pull request.

@GasDauMin
Copy link
Collaborator Author

I might be able to work again, but it's hard to say when, I was hoping there would be time to work at the time that I accidentally did a commit. But at the same time I started working on a second project, and there was no more free time for hobby coding, as much as I would like to :)

@GasDauMin
Copy link
Collaborator Author

GasDauMin commented Dec 23, 2023

However, I can see that it would not take much time to make the right change, I can do it.

end2endzone added a commit that referenced this issue Dec 28, 2023
Improves menu separator parsing with validity/visibility node parsing. Closing #141
@end2endzone end2endzone added this to the 0.9.0 milestone Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants