-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resource identifier for win32 generator #25
Comments
A guid should be used instead of the poor random string generator. |
end2endzone
added a commit
that referenced
this issue
Jan 17, 2019
Using crc32 implementation for generating a unique resource identifier name for Win32ResourceGenerator. |
end2endzone
added a commit
that referenced
this issue
Jan 18, 2019
* cmake_support: (30 commits) Fixed .travis.yml line 104: ./test_script: No such file or directory Fixed unit test execution on Travis CI. Fixed error: ‘strlen’ was not declared in this scope. Fixed error: ‘sprintf’ was not declared in this scope. Fixed indentation for crc32.cpp * Fixed issue #25: Resource identifier for win32 generator. * Fixed unit test `TestExtraction.testGeneratorWin32()` on Windows platform. * Added `virtual` keyword to generated destructor code of all generators. Fixed compilation on AppVeyor and Travis CI. Delete file prebuild.cmake which was renamed to generate_test_files.cmake * Deleted targetver.h * Fixed issue #24: License copy in all source and include files. * Generators generate files with appropriate include guard. Removed all `#pragma once` statements in the code. * Renamed prebuild.cmake to generate_test_files.cmake * Modified add_custom_command() action for Windows platform. Now using the same logic as on Linux: add_custom_command() delegate the executables path to file 'generate_test_files.cmake' which generates the appropriate script 'generate_test_files.bat' or 'generate_test_files.sh'. Modified CMake scripts for Linux to copy the file generation script to CMAKE_CURRENT_BINARY_DIR to allow unit test compilation and to build/bin directory to allow unit test execution. Fixed warning: format ‘%u’ expects argument of type ‘unsigned int’, but argument 4 has type ‘size_t {aka long unsigned int}’ Fixed error copying file "generate_test_files.sh" to "/home/travis/build/end2endzone/bin2cpp/build/bin". Fixed warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘size_t {aka long unsigned int}’ Fixed warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘uint32_t {aka unsigned int}’ Fixed warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘long int’ Fixed compilation issue for testfilegenerator.cpp on Linux. Fixed compilation on Linux (again). Fixed include directories for all generated test files. Disabled generated files on Linux which can only be compiled on the Windows platform. Fixed generation of test files by properly using path separator for each platform. ...
Fixed in 079cf2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The resource identifier contains
html5skeleton
in the string which is debugging code. Thehtml5skeleton
section should be removed.The text was updated successfully, but these errors were encountered: