Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scale functionality should be separated #60

Open
endail opened this issue Jan 6, 2023 · 3 comments
Open

Scale functionality should be separated #60

endail opened this issue Jan 6, 2023 · 3 comments
Assignees
@endail
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request

Comments

@endail
Copy link
Owner

endail commented Jan 6, 2023

This repo should focus solely on communicating with a HX711. Functionality built on top, such as a scale for measuring weight, is out of scope and should be removed/moved into its own repo.
@endail endail added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Jan 6, 2023
@endail endail pinned this issue Jan 6, 2023
@endail endail mentioned this issue Jan 6, 2023
Open
@endail
Copy link
Owner Author

endail commented Jan 6, 2023

A rpi-scale-cxx repo should be created for the scale functions.

@endail
Copy link
Owner Author

endail commented Jan 7, 2023

Classes to be removed:

AbstractScale
Mass
Value
ValueStack

@endail endail self-assigned this Jan 8, 2023
endail added a commit that referenced this issue Jan 8, 2023
@endail
Scale functionality should be removed
563c265 
Fixes #60
@endail endail closed this as completed Jan 8, 2023
@endail
Copy link
Owner Author

endail commented Jan 12, 2023

On second thought, having scale functionality as part of a "library" should persist, but should be more clearly separated from the base HX711 functionality.

@endail endail changed the title Scale functionality should be removed Scale functionality should be separated Jan 12, 2023
@endail endail reopened this Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@endail endail

Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@endail