Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show and hide user gist #4

Closed
enderahmetyurt opened this issue Oct 12, 2018 · 12 comments
Closed

Show and hide user gist #4

enderahmetyurt opened this issue Oct 12, 2018 · 12 comments

Comments

@enderahmetyurt
Copy link
Owner

On user gist page show and hide gist by clicking gist link

@shivanibhanwal
Copy link
Collaborator

Yes @enderahmetyurt I have planned, already started with that I think by tomorrow I should be able to do that. My assumption is to just get the gist content and display in the content section on click of list view.

@enderahmetyurt
Copy link
Owner Author

Yes. You can do it with your assumption. I want to show an example of what I really want. https://getbootstrap.com/docs/4.0/components/collapse/ When the user clicks the gist name on the list and open a div which includes gist codes and then click again the link div should be close.

@shivanibhanwal
Copy link
Collaborator

@enderahmetyurt 👍 we thought same thing I planned it this way https://getbootstrap.com/docs/4.0/components/list-group/#javascript-behavior

@enderahmetyurt
Copy link
Owner Author

No. I guess we should do toggle below the gist link. Because opening it left of the link cannot be fit in a div or it should be smaller. Can you do it as I mentioned?

@shivanibhanwal
Copy link
Collaborator

On I forgot to mention I am taking the approach of list_group but I am doing it below the List item, not on right @enderahmetyurt
which is same as your example difference is I am not using accordion

@shivanibhanwal
Copy link
Collaborator

@enderahmetyurt I have completed implementation of show/hide. Attached is the screenshot. Only thing which I have some issue is with the Content displaying as it comes in gist editor because every file is of different format e.g .rb, .md
I tried Redcarpet Markdown and Rouge syntax highlighter, but markdown changes it to HTML which is not case with all the gist. I explored Rouge but need to see if we can do that based on just file extension with Rouge. But for now I am committing changes. Let me know your thought
screen shot 2018-10-17 at 9 21 07 pm

@enderahmetyurt
Copy link
Owner Author

Thank you @shivanibhanwal but it's not working properly.
screen shot 2018-10-17 at 22 52 27

I want to make some color with Redcarpet. Gist API gives the extension of the gist. It doesn't make any sense with raw html.

@shivanibhanwal
Copy link
Collaborator

@enderahmetyurt Markdown redcarpet will not help with syntax highlitghter only that case be changed. I need to explore that more.

@enderahmetyurt
Copy link
Owner Author

Okay. Could you fix the accordion problem?

@shivanibhanwal
Copy link
Collaborator

Hi, @enderahmetyurt I have fixed it completely will be raising PR in a few minutes. It has many cases to handle. The accordion issue was because one gist can have Many Files in it. So I have handled it too
screen shot 2018-10-18 at 7 40 34 pm
screen shot 2018-10-18 at 7 40 50 pm

@enderahmetyurt
Copy link
Owner Author

Great. It looks nice @shivanibhanwal I will be check later. Thanks 🙏

shivanibhanwal referenced this issue in shivanibhanwal/gistcatch Oct 18, 2018
- handled gist with multiple file option
- Implemented syntax highlighting
@shivanibhanwal
Copy link
Collaborator

@enderahmetyurt it is complete now you can check the changes and let me know.

enderahmetyurt referenced this issue Oct 18, 2018
Fixes#4 Added Method to get the Gist Content
enderahmetyurt referenced this issue Oct 21, 2018
Fixes#4 Unnecessary call to the gitapi on accordion card collapse
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants