-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various improvements to the website. #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't spin anything up locally, just a ultra-quick glance at the new page.
plugin-manifest-gen.html
Outdated
} | ||
}) | ||
.then(json => json.licenses.filter(l => !l.isDeprecatedLicenseId)) | ||
.then(list => licenses = list) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No global variables. Use let or const to declare it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a let licenses = [];
. Does that fix it? I'm a total beginner in JS.
?
... and the latter is true for myself, as well. Please remove it! As my token addition... ... Having said that, i.e., P.S. I really appreciate all y'all! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't speak to the code; but the proposed changes look like good ones.
This PR changes the following:
That's it!
Screenshots