Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements to the website. #28

Merged
merged 2 commits into from
Jan 25, 2023

Conversation

quyykk
Copy link
Member

@quyykk quyykk commented Jun 29, 2022

This PR changes the following:

  • Adds the jekyll generated site to .gitignore
  • Adds a new panel on the sidebar that links to Github, Steam and the Discord.
  • The Downloads link now points to the latest release instead of the general releases page.
  • Adds a helpful website to generate a plugin manifest file for the repo (courtesy of @MCOfficer, all credit goes to him)
  • Fixes the render thumbnails being drawn over the fullscreen gallery image.
  • Removed all the irrelevant text on the plugins page (I plan on adding that information on the ES Wiki for creating plugins)
  • Changed the default amount of plugins shown to 50.
  • Added two sentences to the plugins page that links to the ES Wiki on how to add your plugin to the repo (I will publish that page if this PR gets merged)
  • Added a title to the plugins page.
  • Changed the Forums link to the Github Discussions link (since the Google Forums are dead).

That's it!

Screenshots

image

image

Copy link
Contributor

@Amazinite Amazinite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice.

Copy link
Collaborator

@tehhowch tehhowch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't spin anything up locally, just a ultra-quick glance at the new page.

plugin-manifest-gen.html Outdated Show resolved Hide resolved
}
})
.then(json => json.licenses.filter(l => !l.isDeprecatedLicenseId))
.then(list => licenses = list)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No global variables. Use let or const to declare it.

Copy link
Member Author

@quyykk quyykk Jul 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a let licenses = [];. Does that fix it? I'm a total beginner in JS.

@jwmh
Copy link

jwmh commented Jan 8, 2023

?
Public website at https://endless-sky.github.io/ still lists inaccessible-to-newcomers GoogleGroups link
see endless-sky/endless-sky#5743 (comment)

Zitchas commented on Jun 5, 2021
...
For accounts that have NOT visited it before:

  • 0 [people said] : I can view the group while signed into an account that has never visited it before.
  • 48 [people said] : I can NOT view the group while signed into an account that has never visited it before.

... and the latter is true for myself, as well.
As a newcomer,
I CANNOT visit the GoogleGroups link from the website.

Please remove it!
(Worry about adding other more appropriate links later.)

As my token addition...
I also fully agree w a dev's point:
It is actively harmful to the "optics" of this project for [newcomer] folks to see an inaccessible Forums link.

... Having said that,
"Be careful what you wish for."

i.e.,
As other website-admins have noted...
... Sometimes, more convenience creates attracts lower-quality comments.
... which are an even bigger pain to administer / moderate!

P.S.
Apologies; I assume this has simply been overlooked as part of volunteer-devs' time who are (much more importantly!) working on improving the game itself ;)

I really appreciate all y'all!
You're great.
Seriously.

Copy link
Member

@Zitchas Zitchas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't speak to the code; but the proposed changes look like good ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants