New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
another "unremovable" attempt (enhancement) #2372
Comments
Application One: living bodies in space A coalition or other form ob symbiotic coexistence of a rather "human-like" species (including the arach, kimek etc.) and at least one species of organisms living in space, like may be the bodies of the Pug ships or the Archons.
|
Application Two: existing but blocked weapon hardmounts
|
Application Three: blast marks LORE: each ship can have many, many blast marks. The more it has, the longer its history or the bigger the battles it fought in. Either way, these may even make a ship more valuable - being a famous ship... That's why I decided for positive price tags for the blast marks! Otherwise they'd be negative
Note: adding the correct blast mark type to a ship requires the game to be aware of who built the ship originally which might be achieved with some attribute (probably cant be checked in conditions and branches?!?) or alternatively with some faction outfit saying "This is a human ship" / "This is a hai ship" / "This is a coalition ship".
|
Application Four: ship tuning (variants) This includes the option to re-write some existing variants (not really intended) but also (that's the relevant application topic) the chance to modify your ship after you bought it, without selling it...
|
Application Five: empty placeholder |
you really don't have to copy-paste several missions in every issue, just simply saying what's up does too |
Okay, this is gonna be a long post. Just saying in advance...
And I do not follow the original intention of #1780 and also want to achieve some different aspects than in #1412. That's why I prefer to open a new thread in order to not go too much offtopic in the other issues.
I jumped from pull #1935 to pull #2037, then to issue #1763, then to #1412 and from there finally to #1413 and #1780.
And it didnt take even a whole single day (24 hours) to perform these jumps, even without having any Hyperdrive at home, nor any hyperspace fuel ;-)
Following cd23758, the first commit in #1413, I found out myself, that this is not enough.
I tested in the game (v0.9.6) again, what happens when you try to sell a
Local Map
or aPilot's License
.I modified my latest savegame of my 2nd pilot, Lydia S, as follows:
Those Korath Piercers were intentionally placed, without having a launcher or storage depot.
Loading this, resulted in some "nice" effects:
"installable" -1 makes things uninstallable already.
Or do I miss any way to uninstall an installed item into cargo space without selling it?This told me, that https://github.com/endless-sky/endless-sky/blob/master/source/OutfitterPanel.cpp#L521 would not be the point where to implement the
unremovable
tag. This only gives the error when clicking on the greyed out sell button. Still a good thing to do when implementingunremovable
but not the most important section.I got to the point of CanSell() in Line 442.
I decided it would be best to add a check just below the Cargo() check, i.e. allowing the unremovable items to be sold as long as they have not been installed (some games refer this to "bind on equip", BoE), which allows for interesting missios where you can take such items from freighters which transport outfits from one colony to another as cargo.
I then looked ba23883, the second commit in #1413, and found out Isaac had placed his code just a little bit lower (and didnt finish the return line with a semicolon).
I fully follow the argumentation of @Bladewood in #1780 regarding changing the way of thinking and I follow @Amazinite in #1780 regarding the useless outfits and extra works in terms of images.
I hereby explicitely do NOT follow #1780. And I do not follow #1412 with respect to the fire-while-cloaked line, but refer to @Isaacssv552 in #1412
Oh, and unlike @Sinsling wrote in #1412,
uninstallable
did not make it into 0.9.3 according to the changelog and is not part of the currect code (master, 0.9.6+). So this is not available right now. And @Amazinite is wrong saying"installable" -1 makes things uninstallable already.
I agree with @endless-sky in #1412 that a range of applications can already be achieved with negative attributes on the hull. A range of.
I intend to hereby show a few content ranges, explicitely following some of the ideas quote above, which imho would be a mess to achieve this way. Knowing, that any tag (which does not conflict with existing ones) can be used, is good to know...
I will try to shorten any quotes and codes to an acceptable minimum in order to show the idea of - not writing a full lore. And I will reuse standard outfits as far as possible, or simply name some...
For each of the applications I am happily accepting proposal on how to achieve them "nicely" without
unremovable
tag.But lets get to those concepts!
The text was updated successfully, but these errors were encountered: