Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow triggers to play a sound #10008

Merged
merged 25 commits into from
May 8, 2024
Merged

Allow triggers to play a sound #10008

merged 25 commits into from
May 8, 2024

Commits on Apr 21, 2024

  1. Add 'play' to triggers which plays a sound

    @eebop
    eebop committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    a987c95 View commit details
    Browse the repository at this point in the history

  2. Update source/GameAction.cpp 

    Co-authored-by: Amazinite <jsteck2000@gmail.com>
    @eebop @Amazinite
    eebop and Amazinite committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    3efe9b2 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Amazinite <jsteck2000@gmail.com>
    @eebop @Amazinite
    eebop and Amazinite committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    db84685 View commit details
    Browse the repository at this point in the history

  4. Update source/GameAction.cpp 

    Co-authored-by: Amazinite <jsteck2000@gmail.com>
    @eebop @Amazinite
    eebop and Amazinite committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    fc5d365 View commit details
    Browse the repository at this point in the history

  5. add instantiate

    @eebop
    eebop committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    9259b17 View commit details
    Browse the repository at this point in the history

  6. don't give specific error

    @eebop
    eebop committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    6041126 View commit details
    Browse the repository at this point in the history

  7. add quiet, which stops all sounds

    @eebop
    eebop committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    7654ea9 View commit details
    Browse the repository at this point in the history

  8. Update source/GameAction.cpp 

    Co-authored-by: TomGoodIdea <108272452+TomGoodIdea@users.noreply.github.com>
    @eebop @TomGoodIdea
    eebop and TomGoodIdea committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    d76cdb6 View commit details
    Browse the repository at this point in the history

  9. switch 'play' to 'music'

    @eebop
    eebop committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    d52d1b6 View commit details
    Browse the repository at this point in the history

  10. Update source/GameAction.cpp 

    Co-authored-by: TomGoodIdea <108272452+TomGoodIdea@users.noreply.github.com>
    @eebop @TomGoodIdea
    eebop and TomGoodIdea committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    58fb797 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. add <ambient> as a possible sound; this plays the default sound in th… 

    …e system or planet
    @eebop
    eebop committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    374ddd6 View commit details
    Browse the repository at this point in the history

  2. Update source/GameAction.cpp 

    Co-authored-by: TomGoodIdea <108272452+TomGoodIdea@users.noreply.github.com>
    @eebop @TomGoodIdea
    eebop and TomGoodIdea committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    3e130ca View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. fix quiet, style, disallow music ""

    @eebop
    eebop committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    496829a View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Use .empty

Co-authored-by: TomGoodIdea <108272452+TomGoodIdea@users.noreply.github.com>
    @eebop @TomGoodIdea
    eebop and TomGoodIdea committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    bab6b75 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: TomGoodIdea <108272452+TomGoodIdea@users.noreply.github.com>
    @eebop @TomGoodIdea
    eebop and TomGoodIdea committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    936c428 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Merge branch 'endless-sky:master' into master

    @eebop
    eebop committed May 1, 2024
    Configuration menu
    Copy the full SHA
    5b70eed View commit details
    Browse the repository at this point in the history

Commits on May 4, 2024

  1. apply suggestions

    @eebop
    eebop committed May 4, 2024
    Configuration menu
    Copy the full SHA
    6926938 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into master

    @eebop
    eebop committed May 4, 2024
    Configuration menu
    Copy the full SHA
    e6490e6 View commit details
    Browse the repository at this point in the history

  3. Update source/GameAction.cpp 

    Co-authored-by: Rising Leaf <85687254+RisingLeaf@users.noreply.github.com>
    @eebop @RisingLeaf
    eebop and RisingLeaf committed May 4, 2024
    Configuration menu
    Copy the full SHA
    11e5470 View commit details
    Browse the repository at this point in the history

  4. Update source/GameAction.cpp 

    Co-authored-by: Rising Leaf <85687254+RisingLeaf@users.noreply.github.com>
    @eebop @RisingLeaf
    eebop and RisingLeaf committed May 4, 2024
    Configuration menu
    Copy the full SHA
    07bd383 View commit details
    Browse the repository at this point in the history

  5. Update source/GameAction.cpp 

    Co-authored-by: Rising Leaf <85687254+RisingLeaf@users.noreply.github.com>
    @eebop @RisingLeaf
    eebop and RisingLeaf committed May 4, 2024
    Configuration menu
    Copy the full SHA
    201a590 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2024

  1. Removing unnecessary braces

    @Amazinite
    Amazinite committed May 5, 2024
    Configuration menu
    Copy the full SHA
    60e80d5 View commit details
    Browse the repository at this point in the history

  2. Swap negation

    @Amazinite
    Amazinite committed May 5, 2024
    Configuration menu
    Copy the full SHA
    577a230 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into master

    @Amazinite
    Amazinite committed May 5, 2024
    Configuration menu
    Copy the full SHA
    5c4c1b3 View commit details
    Browse the repository at this point in the history

  4. Alphabetize includes

    @Amazinite
    Amazinite committed May 5, 2024
    Configuration menu
    Copy the full SHA
    e5b70b6 View commit details
    Browse the repository at this point in the history