Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mechanics): Pit boarding attack against boarding defense #10060

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

petervdmeer
Copy link
Member

@petervdmeer petervdmeer commented May 12, 2024

Feature

This PR addresses the bug/feature described in PR #9797 in a different way.

Summary

Boarding attack gets countered by boarding defense of the boarded victim, and the boarded victim can choose to counter-attack or not:

  • The boarding action ends when both parties choose to defend. (As was before)
  • When both sides choose attack, then there are 2 rounds reported; one where the player attacks, and one where the victim attacks.
  • When only one side attacks, then you only see "You attacked" or "They attacked".

Screenshots

attack_and_defend

Usage examples

Just perform attack and defense as before during boarding.

Testing Done

AI is indeed counter-attacking when the chances are good. AI counter-attacks could be improved based on AI personalities.

Save File

N/A; just attack and board some ships. (Or see #9797 for an example with 3 ships to board.)

Performance Impact

None expected.

@petervdmeer petervdmeer marked this pull request as draft May 12, 2024 12:31
@petervdmeer
Copy link
Member Author

(Converted to draft, needs a few more tests and some screenshots.)

@petervdmeer petervdmeer marked this pull request as ready for review May 12, 2024 15:32
@petervdmeer
Copy link
Member Author

Ready for review now.

@petervdmeer petervdmeer changed the title Boarding-attacks vs boarding-defenses feat(mechanics): Pit boarding attack against boarding defense May 12, 2024
Copy link
Contributor

@OcelotWalrus OcelotWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer #9797, but I guess this PR still fixes the issue.

@Quantumshark Quantumshark added the mechanics Things dealing with the mechanics & code of how the game works label May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mechanics Things dealing with the mechanics & code of how the game works
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants