-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mechanics): Properly reset player flagship after death #10128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other two may be done in a separate PR, maybe we just drop the planet panel on death
I think destroying the planet panel on death would fix this issue as well, because without a planet panel the player wouldn't be able to depart |
Simple flagship reset isn't solving anything, here's a screenshot from the outfitter: |
Nvm, I think I got it. |
I think I got all the necessary UI fixes in as well. Do you have a save file for a mid-flight death for testing? |
I would still prefer if you popped the planet panel instead of blocking input |
Looks like I need to do both. |
Co-authored-by: Rising Leaf <85687254+RisingLeaf@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not able to test, but looks good
Tested and working with mid-flight death as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it finally works
Bug fix
This PR addresses the bug described in issue #10125
Summary
Resetting the player flagship seems to fix most issues, except:
Testing Done
Tested with a mission that kills the player on a planet. Needs testing with mid-flight death.