-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planet sprites #3458
planet sprites #3458
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple of planets look a little weird to me, but everything works like it's supposed to (no bugs or anything that was messed up)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the usage count of each sprite now?
Doesn't count excluded sprites(stations etc). Counts after: |
These look really good! For a few of them, the "b" sprite is not the same size as the original, at least based on the sizes in the 2x zip file:
Also, I'm a little worried about cases where the sprite has a very different color, and the landscape photo for a planet was based on the color of the planet sprite. Those would need to be reviewed individually to make sure they still work. |
Fixed the size issues in 59ad726 . However, for some I didn't see a size difference, maybe you meant another sprite? Comparing the zip against the current high-dpi master I get:
Just in case I've edited the first post with a new copy of the 2x.zip with the size changes.
I'll see about a script that'll pull any named objects that got a b variant and start reviewing those. Probably take a bit (maybe more than a bit depending on how many there are). |
what did ya change to water1-b? I can't see any difference |
Nothing. Only the 2x changed size. It's just habit to save in pairs. I'd have to look at it in image magick to know for sure why the hash changed. |
if ya didn't change anything then nothing changed at all; it just resaved as if it's new then |
I took the easy route and just reverted the changes to all named objects in 862d06c . I was about fifty into the review when I realized some of the descriptions referred to the planet sprite, so going through 142 descriptions and checking the landscapes seemed like a waste of time. There's still around 1000 uses of the b variants, so it's a small reversion in the grand scheme. |
these can be added with no fuss about landscapes/descriptions (plus I don't think they get used otherwise)
New planet sprites from @comnom
New planet sprites from @comnom
New planet sprites from @comnom
Didn't manage to snag any other contributers despite having it up on steam for five months so it took a while, but here's the whole set.
I just replaced half of the occurences of a given sprite (rounded down) using a random sample.
2x here (updated):
2x.zip
xcf will be here once its up on google drive:
https://drive.google.com/file/d/1l9E9I12EEi0VZ0pxgRCZGBJBz0-bIDGs/view?usp=sharing