Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planet sprites #3458

Merged
merged 4 commits into from
Jun 1, 2018
Merged

planet sprites #3458

merged 4 commits into from
Jun 1, 2018

Conversation

comnom
Copy link
Contributor

@comnom comnom commented Dec 22, 2017

Didn't manage to snag any other contributers despite having it up on steam for five months so it took a while, but here's the whole set.

I just replaced half of the occurences of a given sprite (rounded down) using a random sample.

2x here (updated):
2x.zip

xcf will be here once its up on google drive:
https://drive.google.com/file/d/1l9E9I12EEi0VZ0pxgRCZGBJBz0-bIDGs/view?usp=sharing

Copy link
Contributor

@Lorantine Lorantine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of planets look a little weird to me, but everything works like it's supposed to (no bugs or anything that was messed up)

Copy link
Collaborator

@tehhowch tehhowch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the usage count of each sprite now?

@comnom
Copy link
Contributor Author

comnom commented Dec 22, 2017

What's the usage count of each sprite now?

Doesn't count excluded sprites(stations etc).
Counts before:
out.txt

Counts after:
outNew.txt

@endless-sky
Copy link
Collaborator

These look really good!

For a few of them, the "b" sprite is not the same size as the original, at least based on the sizes in the 2x zip file:

  • desert1
  • dust7
  • gas1
  • lava3
  • rock1
  • water1

Also, I'm a little worried about cases where the sprite has a very different color, and the landscape photo for a planet was based on the color of the planet sprite. Those would need to be reviewed individually to make sure they still work.

@comnom
Copy link
Contributor Author

comnom commented Dec 28, 2017

For a few of them, the "b" sprite is not the same size as the original, at least based on the sizes in the 2x zip file.

Fixed the size issues in 59ad726 . However, for some I didn't see a size difference, maybe you meant another sprite?

Comparing the zip against the current high-dpi master I get:

  • desert1 at 400x400
  • gas1 at 1600x960
  • rock1 at 340x340

Just in case I've edited the first post with a new copy of the 2x.zip with the size changes.

Those would need to be reviewed individually to make sure they still work.

I'll see about a script that'll pull any named objects that got a b variant and start reviewing those. Probably take a bit (maybe more than a bit depending on how many there are).

@Lorantine
Copy link
Contributor

what did ya change to water1-b? I can't see any difference

@comnom
Copy link
Contributor Author

comnom commented Dec 29, 2017

what did ya change to water1-b? I can't see any difference

Nothing. Only the 2x changed size. It's just habit to save in pairs. I'd have to look at it in image magick to know for sure why the hash changed.

@Lorantine
Copy link
Contributor

if ya didn't change anything then nothing changed at all; it just resaved as if it's new then

@comnom
Copy link
Contributor Author

comnom commented Dec 30, 2017

I took the easy route and just reverted the changes to all named objects in 862d06c .

I was about fifty into the review when I realized some of the descriptions referred to the planet sprite, so going through 142 descriptions and checking the landscapes seemed like a waste of time. There's still around 1000 uses of the b variants, so it's a small reversion in the grand scheme.

these can be added with no fuss about landscapes/descriptions (plus I
don't think they get used otherwise)
@endless-sky endless-sky added this to the 0.9.x milestone Jan 2, 2018
@endless-sky endless-sky merged commit e19a5c9 into endless-sky:master Jun 1, 2018
@comnom comnom deleted the planet-sprites branch June 3, 2018 18:32
temtemy pushed a commit to temtemy/endless-sky that referenced this pull request Jun 12, 2018
Pointedstick pushed a commit to Pointedstick/endless-sky that referenced this pull request Jul 31, 2018
TJesionowski pushed a commit to TJesionowski/endless-sky that referenced this pull request Oct 2, 2018
@tehhowch tehhowch modified the milestones: 0.9.x, 0.9.9 (done) Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants