Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bug): Surviving escorts after FWC Pug 1 attack the Pug in subsequent missions #9710

Closed
wants to merge 12 commits into from

Conversation

ziproot
Copy link
Contributor

@ziproot ziproot commented Jan 22, 2024

Bug fix

This PR addresses the bug described in issue #8832

Summary

When your job is to attack the Pug and steal a jump drive, your escorts just sit there and do nothing. This continues when you re-enter pug space later until you try to retake Oblivion. This PR creates a new government for the escorts. It is attacked by the Pug at first and then the Pug become peaceful. However, when you depart to steal a jump drive, the escorts help you.

Screenshots

image

Testing Done

Made sure the escorts attacked during the escape mission and onward, and during the pug attack at first, but not in between.

Save File

This save file can be used to test these changes:
Test Pilot~Escape!.txt

@bene-dictator bene-dictator added the bug Something in the game is not behaving as intended label Jan 23, 2024
@alexrovw
Copy link
Contributor

Is there a reason we can't use the Escort government as mentioned in #8832 instead of creating a new one?

@ziproot
Copy link
Contributor Author

ziproot commented Jan 23, 2024

The ships aren't your escorts (you can't give them commands). If you get something that changes your swizzle those ships will have changed swizzles as well. If you have negative reputation with the Free Worlds the ships won't attack you, which is inconsistent with other escorts in the game.

@ziproot ziproot marked this pull request as ready for review January 24, 2024 00:02
@alexrovw
Copy link
Contributor

The ships aren't your escorts (you can't give them commands). If you get something that changes your swizzle those ships will have changed swizzles as well. If you have negative reputation with the Free Worlds the ships won't attack you, which is inconsistent with other escorts in the game.

  1. Many non-controllable escorts already use the Escort government, such as the prisoner transport Blackbirds in "FW Southern Prisoners - Release".
  2. Being able to swizzle in the middle of FW would be a bug. You may not change from FW colors while under their employment.
  3. If you have negative reputation with the Free Worlds, you should fail the corresponding mission mission "FWC Checkmate Escorts". I would make that change instead.

@ziproot
Copy link
Contributor Author

ziproot commented Jan 24, 2024

Many non-controllable escorts already use the Escort government, such as the prisoner transport Blackbirds in "FW Southern Prisoners - Release".

I didn't know that. I will switch to the Escort government.

@Amazinite
Copy link
Collaborator

Amazinite commented Jan 24, 2024

If you get something that changes your swizzle those ships will have changed swizzles as well.

We don't write missions from the assumption that the player may have a plugin or may have edited their save file in a way that could break things. Write missions from the assumption that everything is working as intended.

@ziproot
Copy link
Contributor Author

ziproot commented Jan 24, 2024

We don't write missions from the assumption that the player may have a plugin or may have edited their save file in a way that could break things. Write missions from the assumption that everything is working as intended.

That makes sense. Thank you for clarifying.

@Amazinite
Copy link
Collaborator

This might not actually be desirable behavior from the fleet that is with you, which is limited in size until you can relink the Pug occupied systems to the rest of the galaxy. #8832 (comment)

@ziproot
Copy link
Contributor Author

ziproot commented Jan 28, 2024

I didn't realize FW Pug 3A was a non-attack mission

@ziproot ziproot closed this Jan 28, 2024
@ziproot ziproot deleted the pug-anticheat branch January 28, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something in the game is not behaving as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants