-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bug): Surviving escorts after FWC Pug 1 attack the Pug in subsequent missions #9710
Conversation
Is there a reason we can't use the |
The ships aren't your escorts (you can't give them commands). If you get something that changes your swizzle those ships will have changed swizzles as well. If you have negative reputation with the Free Worlds the ships won't attack you, which is inconsistent with other escorts in the game. |
|
I didn't know that. I will switch to the Escort government. |
We don't write missions from the assumption that the player may have a plugin or may have edited their save file in a way that could break things. Write missions from the assumption that everything is working as intended. |
That makes sense. Thank you for clarifying. |
This might not actually be desirable behavior from the fleet that is with you, which is limited in size until you can relink the Pug occupied systems to the rest of the galaxy. #8832 (comment) |
I didn't realize FW Pug 3A was a non-attack mission |
Bug fix
This PR addresses the bug described in issue #8832
Summary
When your job is to attack the Pug and steal a jump drive, your escorts just sit there and do nothing. This continues when you re-enter pug space later until you try to retake Oblivion. This PR creates a new government for the escorts. It is attacked by the Pug at first and then the Pug become peaceful. However, when you depart to steal a jump drive, the escorts help you.
Screenshots
Testing Done
Made sure the escorts attacked during the escape mission and onward, and during the pug attack at first, but not in between.
Save File
This save file can be used to test these changes:
Test Pilot~Escape!.txt