Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SBR-decided shutdowns #222

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Conversation

jchapuis
Copy link
Member

@jchapuis jchapuis commented May 8, 2023

The SBR can decide that the node needs to exit, in which case Akka initiates the application shutdown. We need to make sure that all cats-effect resources are released in such cases. This PR improves mechanisms around application shutdown.

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #222 (8224bbe) into master (66bd15e) will decrease coverage by 0.78%.
The diff coverage is 68.96%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #222      +/-   ##
==========================================
- Coverage   91.15%   90.37%   -0.78%     
==========================================
  Files          55       55              
  Lines         565      582      +17     
  Branches        3        4       +1     
==========================================
+ Hits          515      526      +11     
- Misses         50       56       +6     
Impacted Files Coverage Δ
example/src/main/scala/endless/example/Main.scala 0.00% <0.00%> (ø)
...n/scala/endless/runtime/akka/deploy/Deployer.scala 100.00% <ø> (ø)
.../endless/runtime/akka/deploy/DurableDeployer.scala 75.00% <ø> (ø)
...le/src/main/scala/endless/example/ExampleApp.scala 96.20% <75.00%> (-1.17%) ⬇️
...cala/endless/runtime/akka/deploy/AkkaCluster.scala 92.30% <92.30%> (-7.70%) ⬇️
...ka/deploy/internal/ShardedRepositoryDeployer.scala 100.00% <100.00%> (ø)

@jchapuis jchapuis force-pushed the correct-akka-resource-wrapping branch 3 times, most recently from f75f819 to 9ba4d86 Compare June 1, 2023 13:13
Jonas Chapuis added 2 commits June 1, 2023 15:23
The SBR can decide that the node needs to exit, in which case Akka initiates the application shutdown. We need to make sure that all cats-effect resources are released in such cases
@jchapuis jchapuis force-pushed the correct-akka-resource-wrapping branch from 9ba4d86 to 8224bbe Compare June 1, 2023 13:23
@jchapuis jchapuis merged commit fd30edc into master Jun 1, 2023
1 of 3 checks passed
@jchapuis jchapuis deleted the correct-akka-resource-wrapping branch June 1, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant