Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trigger information to SideEffect #293

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Conversation

jchapuis
Copy link
Member

@jchapuis jchapuis commented Dec 14, 2023

This allows for differentiated side-effects depending on the case (after recovery, persistence or read-only interaction)

@jchapuis jchapuis changed the title Add trigger information to SideEffect to allow for differentiated b… Add trigger information to SideEffect Dec 14, 2023
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Merging #293 (5b8e3db) into master (f9f41be) will decrease coverage by 0.15%.
Report is 6 commits behind head on master.
The diff coverage is 91.42%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #293      +/-   ##
==========================================
- Coverage   89.90%   89.76%   -0.15%     
==========================================
  Files          72       73       +1     
  Lines         872      879       +7     
  Branches       98      116      +18     
==========================================
+ Hits          784      789       +5     
- Misses         88       90       +2     
Files Coverage Δ
...oy/internal/DurableShardedRepositoryDeployer.scala 92.10% <100.00%> (+0.21%) ⬆️
...ternal/EventSourcedShardedRepositoryDeployer.scala 84.44% <100.00%> (+0.35%) ⬆️
.../main/scala/endless/example/app/akka/AkkaApp.scala 100.00% <100.00%> (ø)
...ain/scala/endless/example/app/pekko/PekkoApp.scala 100.00% <100.00%> (ø)
.../endless/example/logic/BookingEntityBehavior.scala 90.90% <ø> (ø)
...cala/endless/example/logic/BookingSideEffect.scala 91.66% <ø> (ø)
.../endless/example/logic/VehicleEntityBehavior.scala 100.00% <ø> (ø)
...cala/endless/example/logic/VehicleSideEffect.scala 100.00% <100.00%> (ø)
...deploy/internal/DurableShardedEntityDeployer.scala 92.10% <100.00%> (+0.21%) ⬆️
...y/internal/EventSourcedShardedEntityDeployer.scala 84.78% <100.00%> (+0.69%) ⬆️
... and 2 more

@jchapuis jchapuis merged commit eaa96e5 into master Dec 18, 2023
2 of 3 checks passed
@jchapuis jchapuis deleted the side-effect-upon-reads branch December 18, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants