Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change RepositoryInterpreter to return a Resource #294

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

jchapuis
Copy link
Member

@jchapuis jchapuis commented Jan 9, 2024

So that finalizable operations required by the repository can be bundled with the overall repository finalization

So that finalizable operations required by the repository can be bundled with the overall repository finalization
Copy link

what-the-diff bot commented Jan 9, 2024

PR Summary

  • Refactoring of Akka and Pekko Entity Creation in ShardedRepositoryDeployer
    The code block that creates and initializes sharding for both Akka and Pekko entities has been improved in ShardedRepositoryDeployer.scala. The previous Resource.eval block has been replaced with a map block

  • Adjustment of Return Type in RepositoryInterpreter
    In the apply method of RepositoryInterpreter.scala, the way the function responds has been revised. It will now return a Resource instead of F[RepositoryAlg].

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eaa96e5) 89.76% compared to head (1e2ae75) 89.73%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #294      +/-   ##
==========================================
- Coverage   89.76%   89.73%   -0.03%     
==========================================
  Files          73       73              
  Lines         879      877       -2     
  Branches      116       94      -22     
==========================================
- Hits          789      787       -2     
  Misses         90       90              
Files Coverage Δ
...ka/deploy/internal/ShardedRepositoryDeployer.scala 100.00% <100.00%> (ø)
...endless/core/interpret/RepositoryInterpreter.scala 100.00% <100.00%> (ø)
...ko/deploy/internal/ShardedRepositoryDeployer.scala 100.00% <100.00%> (ø)

@jchapuis jchapuis merged commit 073fcf7 into master Jan 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant