Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish the Endless Key app on Flathub #5

Closed
dbnicholson opened this issue Aug 18, 2023 · 23 comments
Closed

Publish the Endless Key app on Flathub #5

dbnicholson opened this issue Aug 18, 2023 · 23 comments
Assignees

Comments

@dbnicholson
Copy link
Member

We want to avoid Endless users installing the Endless Key app until after our OS image has been updated to include the Endless Key version of eos-kolibri-system-helper.

@starnight
Copy link
Contributor

App Submission shows how to submit a new application to Flathub.

@starnight
Copy link
Contributor

GNOME 44 flatpak runtime's Python is version 3.10:

$ flatpak run --command=python org.gnome.Platform//44 --version
Python 3.10.12

@starnight
Copy link
Contributor

Another question: Which open source License should we use for this project?
Still the MIT like org.learningequality.Kolibri? Or, others?

@starnight
Copy link
Contributor

I think this is blocked on Create a flatpak manifest for an Endless Key app

@starnight
Copy link
Contributor

The working is at https://github.com/starnight/flathub/tree/org.endlessos.Key
Have some temporary files first.

@dbnicholson
Copy link
Member Author

@starnight I think we have enough now that you can start the submission process. We'll still have to work out a few bugs, but I'd like to get the flathub review going in parallel.

@starnight
Copy link
Contributor

@starnight
Copy link
Contributor

According to Flathub's Requirements, it only accepts stable application releases. So, I release endless-key-flatpak as the tag endlesskey_1.0.0.

Because, endless-key-flatpak might do rebase action based on upstream kolibri-installer-gnome in the future. I add the tag with prefix endlesskey_.

Use the number 1.0.0 as the publish baseline now. We can sync up the version of kolibri-explore-plugin after we include kolibri-explore-plugin, like endless-key-app and kolibri-installer-android.

@starnight
Copy link
Contributor

I created the PR Add org.endlessos.Key to Flathub!

@dbnicholson
Copy link
Member Author

Before we get too far, can we roll the version back to 0.1? I would not call the current version 1.0.0 because it support the explore plugin yet.

@dbnicholson
Copy link
Member Author

I created #24 to set the version back to 0.1 and hope we can use the simpler vX.Y as the tag. I think the endlesskey_ in the tag names is superfluous.

@dbnicholson
Copy link
Member Author

According to Flathub's Requirements, it only accepts stable application releases. So, I release endless-key-flatpak as the tag endlesskey_1.0.0.

Because, endless-key-flatpak might do rebase action based on upstream kolibri-installer-gnome in the future. I add the tag with prefix endlesskey_.

Use the number 1.0.0 as the publish baseline now. We can sync up the version of kolibri-explore-plugin after we include kolibri-explore-plugin, like endless-key-app and kolibri-installer-android.

I think it's very unlikely we'll do any more rebases from kolibri-installer-gnome as we further diverge. Possibly there can be some cherry picks in either direction, but the last rebase was already pretty messy and duplicated commits that originated here.

Changing the version number is to me a pretty clear indication that this is a separate application with its own development. The more likely approach is that the common work goes into a Kolibri base app (#2) and then there's definitely no reason for further shared development history between the apps.

@dbnicholson
Copy link
Member Author

#24 was merged, so I created a v0.1 tag and added a suggestion on the flathub PR to adjust accordingly.

@cassidyjames
Copy link
Member

I don't think it makes sense to publish publicly to Flathub until we actually ship the Endless Key experience (the Explore plugin, if I'm understanding things correctly?). As of right now, it would just come off as Kolibri with a different name, which is a really awkward launch.

…Unless I'm missing something, here.

@dbnicholson
Copy link
Member Author

Yes, but I'm hoping to get a little parallel path effort here. What I don't want is to have the Endless Key experience all polished up and ready to be used and then we can't actually install it anywhere because we're waiting for it to be processed by Flathub.

I'd personally rather get the Flathub setup ready while we iterate. To me, exists on Flathub != launch the app. Which is also why I rolled the version back to 0.1. However, you likely have more experience here. If you think it's better to not have it exist on Flathub until we're ready for the world to see it and you feel like we can get the submission process done in a timely manner, then I don't mind waiting.

@starnight
Copy link
Contributor

The new test version is built by Flathub flathub/flathub#4481 (comment)

@dbnicholson
Copy link
Member Author

We're live!

https://github.com/flathub/org.endlessos.Key

If I understand this comment correctly, @starnight will be invited to collaborate. I think we actually want Endless organization collaboration, which we've done for other apps. I don't remember how that's done, though. @cassidyjames @GeorgesStavracas ?

@dbnicholson
Copy link
Member Author

Per Bart on flathub matrix:

merged and added flathub/endless to collaborators

So, I guess however is in the flathub/endless team. I'm not sure who that is, though.

@cassidyjames
Copy link
Member

cassidyjames commented Sep 15, 2023

@dbnicholson I think Rob, Will, and I are in that team at least, but yeah we should request @endlessm or @endlessm/endless-developers I think

@cassidyjames
Copy link
Member

It's now live and verified. https://flathub.org/apps/org.endlessos.Key

@dbnicholson
Copy link
Member Author

@dbnicholson I think Rob, Will, and I are in that team at least, but yeah we should request @endlessm or @endlessm/endless-developers I think

It appears I'm in it since I was automatically subscribed and can do some privileged things. I think Will got most if not all of the engineers added.

@vanessa-chang
Copy link

Verified passed as it's available in the stable branch

@wjt
Copy link
Member

wjt commented Oct 31, 2023

@dbnicholson you and I are labelled as "maintainers" of the https://github.com/orgs/flathub/teams/endless/members team. I have just removed Philip from that group :(

I'm not sure to whom the group is visible. The remaining members as of now are (in no particular order, thanks GitHub):

dsd
manuq
wjt
dylanmccall
ramcq
cassidyjames
starnight
dbnicholson
vanessa-chang

I think that's right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants