Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Key on EOS: biohazard item is irritating #51

Closed
erikos opened this issue Sep 13, 2023 · 2 comments · Fixed by #54 or #53
Closed

Key on EOS: biohazard item is irritating #51

erikos opened this issue Sep 13, 2023 · 2 comments · Fixed by #54 or #53

Comments

@erikos
Copy link
Contributor

erikos commented Sep 13, 2023

Let’s remove the biohazard icon and say (Beta) or something similar.

Screenshot from 2023-09-13 15-41-06
Screenshot from 2023-09-13 15-39-31
dylanmccall added a commit that referenced this issue Sep 13, 2023
@dylanmccall
Add the "devel" CSS class for development builds
1284f41 
The main window should be styled to reflect that it is a development
build.

Helps: #51
@dylanmccall
Copy link
Contributor

This is specific to builds of org.endlessos.Key.Devel, just following a pattern that is used for many other GNOME apps. Unless #5 gets completely stalled, I don't think in two weeks we'll be installing .Devel builds for any case outside of a developer testing a build on their own system. But if that's definitely an issue in the short term, I think changing "☢️" to "(Nightly)" makes fine sense, and I also created #53 to make sure we are communicating that it is a development build in all the usual ways.

dylanmccall added a commit that referenced this issue Sep 13, 2023
@dylanmccall
Change the development build name suffix to "(Nightly)"
bde5f96 
The previous "☢️" suffix was considered to be too alarming.

Closes: #51
This was referenced Sep 13, 2023
Merged
Merged
@dylanmccall dylanmccall linked a pull request Sep 13, 2023 that will close this issue
Add the "devel" CSS class for development builds #53
Merged
dylanmccall added a commit that referenced this issue Sep 13, 2023
@dylanmccall
Change the development build name suffix to "(Dev)"
05e72d3 
The previous "☢️" suffix was considered to be too alarming.

Closes: #51
@erikos
Copy link
Contributor Author

erikos commented Sep 15, 2023

Yes, not visible when installing from Flathub. Thanks for the explanation @dylanmccall

dylanmccall added a commit to learningequality/kolibri-installer-gnome that referenced this issue Apr 24, 2024
@dylanmccall
Add the "devel" CSS class for development builds
cb2b56f 
The main window should be styled to reflect that it is a development
build.

Helps: endlessm/endless-key-flatpak#51
dylanmccall added a commit to learningequality/kolibri-installer-gnome that referenced this issue Apr 24, 2024
@dylanmccall
Change the development build name suffix to "(Dev)"
90d31e4 
The previous "☢️" suffix was considered to be too alarming.

Closes: endlessm/endless-key-flatpak#51
dylanmccall added a commit to learningequality/kolibri-installer-gnome that referenced this issue May 4, 2024
@dylanmccall
Add the "devel" CSS class for development builds
0c2f7d7 
The main window should be styled to reflect that it is a development
build.

Helps: endlessm/endless-key-flatpak#51
dylanmccall added a commit to learningequality/kolibri-installer-gnome that referenced this issue May 4, 2024
@dylanmccall
Change the development build name suffix to "(Dev)"
80ca020 
The previous "☢️" suffix was considered to be too alarming.

Closes: endlessm/endless-key-flatpak#51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@dylanmccall @erikos