Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple systemd service to migrate shotwell to flatpak #356

Merged
merged 1 commit into from Nov 1, 2021

Conversation

BryanQuigley
Copy link
Contributor

@BryanQuigley BryanQuigley commented Oct 10, 2021

Worked in my initial testing - but somehow I broke flatpak shotwell's ability to install (unrelated building of it).

Thoughts on this approach?

https://phabricator.endlessm.com/T31431

@eos-shell-build
Copy link

I don't recognize the submitter as a member of @endlessm. Can somebody in @endlessm verify the patch? See https://phabricator.endlessm.com/w/software/build/ci-integration/#pull-requests for more details.

@BryanQuigley
Copy link
Contributor Author

This works. (My issue was my partition got corrupted while installing shotwell so there was extra data that could not be removed in ostree..)

Copy link
Contributor

@pwithnall pwithnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM.

@pwithnall
Copy link
Contributor

Not landing this yet as the change to drop Shotwell from the default OSTree needs to be reviewed too, and all the changes land together. Thanks for the PR!

@pwithnall pwithnall merged commit b9e5d19 into endlessm:master Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants