Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildscript: Declare repo as a git safe directory #105

Merged
merged 1 commit into from Feb 24, 2023
Merged

Conversation

dbnicholson
Copy link
Member

Newer git prevents operations when the calling user is not the same as the user owning the repo. Currently the only git operation run is git rev-parse HEAD to record the builder commit in the manifest, but even that is enough to make git fail. Add the repo as a safe directory inside the build root since the builder is running as root and the repo may not be owned by root.

https://community.endlessos.com/t/custom-build-problem-with-5-0/19900

Newer git prevents operations when the calling user is not the same as
the user owning the repo. Currently the only git operation run is `git
rev-parse HEAD` to record the builder commit in the manifest, but even
that is enough to make git fail. Add the repo as a safe directory inside
the build root since the builder is running as root and the repo may not
be owned by root.

https://community.endlessos.com/t/custom-build-problem-with-5-0/19900
Copy link
Contributor

@jprvita jprvita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it will do the right thing (although I haven't tested it). Feel free to merge.

@wjt wjt merged commit 99abce5 into master Feb 24, 2023
@wjt wjt deleted the git-safe-directory branch February 24, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants