Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation for paths in config #166

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add validation for paths in config #166

wants to merge 2 commits into from

Commits on Jun 21, 2024

  1. Add validation for paths in config 

    Previously, if a filename referred to in the configuration does not
exist, that would only be discovered when the hook which uses that key
runs, which may be minutes or hours into the build.

Add a way to specify in the schema that certain keys must be set to a
single path to an extant file, or a list of paths to extant files.

https://phabricator.endlessm.com/T35517
    @wjt
    wjt committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    8e28a7c View commit details
    Browse the repository at this point in the history

  2. Specify path(s) types in config schema 

    Based on a quick review of the hooks in this repo, I think this covers
all the likely candidates.

https://phabricator.endlessm.com/T35517
    @wjt
    wjt committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    0775b73 View commit details
    Browse the repository at this point in the history