eos-paygd: Fix meson conflation between eos-paygd.conf output files #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If meson has two configure_file() rules with the same output in the same directory, one of them will silently overwrite the other. This was causing the sysusers.d rules to be installed in the tmpfiles.d directory as well as the sysusers.d directory, and causing tmpfiles.d to fail. Fix that by renaming the eos-paygd.conf for tmpfiles.d to eos-paygd-state.conf, taking advantage of tmpfiles.d’s support for ‘parts’ of packages. Signed-off-by: Philip Withnall <withnall@endlessm.com> https://phabricator.endlessm.com/T21730
|
I looked at filing this as an upstream issue, but it looks like it’s covered by these two already: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only needs to be merged on eos3.3.
If meson has two configure_file() rules with the same output in the same
directory, one of them will silently overwrite the other. This was
causing the sysusers.d rules to be installed in the tmpfiles.d directory
as well as the sysusers.d directory, and causing tmpfiles.d to fail.
Fix that by renaming the eos-paygd.conf for tmpfiles.d to
eos-paygd-state.conf, taking advantage of tmpfiles.d’s support for
‘parts’ of packages.
Signed-off-by: Philip Withnall withnall@endlessm.com
https://phabricator.endlessm.com/T21730